From 302d4e6fdb59f31c887d1605eb40e0ae5d1f951f Mon Sep 17 00:00:00 2001
From: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Mon, 27 Nov 2023 22:10:50 +0000
Subject: [PATCH] Small validation fixes

  - prevent repeated IDs in mastodon icon SVG
  - fix missing offset attribute in mastodon icon SVG
  - remove un-needed role on <nav> element
  - add empty alt attribute to some social icons
---
 resources/views/templates/mini-hcard.blade.php   | 4 ++--
 resources/views/templates/note.blade.php         | 1 +
 resources/views/templates/pagination.blade.php   | 2 +-
 resources/views/templates/social-links.blade.php | 6 +++---
 4 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/resources/views/templates/mini-hcard.blade.php b/resources/views/templates/mini-hcard.blade.php
index dc0c2c8c..36bd4caa 100644
--- a/resources/views/templates/mini-hcard.blade.php
+++ b/resources/views/templates/mini-hcard.blade.php
@@ -4,12 +4,12 @@
         <img class="u-photo" alt="" src="{{ $contact->photo }}">
         @if ($contact->facebook)
             <a class="u-url" href="https://www.facebook.com/{{ $contact->facebook }}">
-                <img class="social-icon" src="/assets/img/social-icons/facebook.svg"> Facebook
+                <img class="social-icon" src="/assets/img/social-icons/facebook.svg" alt=""> Facebook
             </a>
         @endif
         @if ($contact->twitter)
             <a class="u-url" href="https://twitter.com/{{ $contact->twitter }}">
-                <img class="social-icon" src="/assets/img/social-icons/twitter.svg"> {{ $contact->twitter }}
+                <img class="social-icon" src="/assets/img/social-icons/twitter.svg" alt=""> {{ $contact->twitter }}
             </a>
         @endif
     </span>
diff --git a/resources/views/templates/note.blade.php b/resources/views/templates/note.blade.php
index eef657ff..83b799d4 100644
--- a/resources/views/templates/note.blade.php
+++ b/resources/views/templates/note.blade.php
@@ -74,6 +74,7 @@
                     $note->mastodon_url
                 )
                     @include('templates.social-links', [
+                        'id' => $note->id,
                         'tweet_id' => $note->tweet_id,
                         'facebook_url' => $note->facebook_url,
                         'swarm_url' => $note->swarm_url,
diff --git a/resources/views/templates/pagination.blade.php b/resources/views/templates/pagination.blade.php
index bbe417bd..9f335afd 100644
--- a/resources/views/templates/pagination.blade.php
+++ b/resources/views/templates/pagination.blade.php
@@ -1,5 +1,5 @@
 @if ($paginator->hasPages())
-    <nav role="navigation" class="pagination">
+    <nav class="pagination">
         <div>
             @if ($paginator->onFirstPage())
                 <span>
diff --git a/resources/views/templates/social-links.blade.php b/resources/views/templates/social-links.blade.php
index cdfeb619..95aa1092 100644
--- a/resources/views/templates/social-links.blade.php
+++ b/resources/views/templates/social-links.blade.php
@@ -29,11 +29,11 @@
 </a>@endif
 @if($mastodon_url !== null)<a class="u-syndication" href="{{ $mastodon_url }}" title="View note on Mastodon">
     <svg width="75" height="79" viewBox="0 0 75 79" fill="none" xmlns="http://www.w3.org/2000/svg">
-        <path d="M73.8393 17.4898C72.6973 9.00165 65.2994 2.31235 56.5296 1.01614C55.05 0.797115 49.4441 0 36.4582 0H36.3612C23.3717 0 20.585 0.797115 19.1054 1.01614C10.5798 2.27644 2.79399 8.28712 0.904997 16.8758C-0.00358524 21.1056 -0.100549 25.7949 0.0682394 30.0965C0.308852 36.2651 0.355538 42.423 0.91577 48.5665C1.30307 52.6474 1.97872 56.6957 2.93763 60.6812C4.73325 68.042 12.0019 74.1676 19.1233 76.6666C26.7478 79.2728 34.9474 79.7055 42.8039 77.9162C43.6682 77.7151 44.5217 77.4817 45.3645 77.216C47.275 76.6092 49.5123 75.9305 51.1571 74.7385C51.1797 74.7217 51.1982 74.7001 51.2112 74.6753C51.2243 74.6504 51.2316 74.6229 51.2325 74.5948V68.6416C51.2321 68.6154 51.2259 68.5896 51.2142 68.5661C51.2025 68.5426 51.1858 68.522 51.1651 68.5058C51.1444 68.4896 51.1204 68.4783 51.0948 68.4726C51.0692 68.4669 51.0426 68.467 51.0171 68.4729C45.9835 69.675 40.8254 70.2777 35.6502 70.2682C26.7439 70.2682 24.3486 66.042 23.6626 64.2826C23.1113 62.762 22.7612 61.1759 22.6212 59.5646C22.6197 59.5375 22.6247 59.5105 22.6357 59.4857C22.6466 59.4609 22.6633 59.4391 22.6843 59.422C22.7053 59.4048 22.73 59.3929 22.7565 59.3871C22.783 59.3813 22.8104 59.3818 22.8367 59.3886C27.7864 60.5826 32.8604 61.1853 37.9522 61.1839C39.1768 61.1839 40.3978 61.1839 41.6224 61.1516C46.7435 61.008 52.1411 60.7459 57.1796 59.7621C57.3053 59.7369 57.431 59.7154 57.5387 59.6831C65.4861 58.157 73.0493 53.3672 73.8178 41.2381C73.8465 40.7606 73.9184 36.2364 73.9184 35.7409C73.9219 34.0569 74.4606 23.7949 73.8393 17.4898Z" fill="url(#paint0_linear_549_34)"/>
+        <path d="M73.8393 17.4898C72.6973 9.00165 65.2994 2.31235 56.5296 1.01614C55.05 0.797115 49.4441 0 36.4582 0H36.3612C23.3717 0 20.585 0.797115 19.1054 1.01614C10.5798 2.27644 2.79399 8.28712 0.904997 16.8758C-0.00358524 21.1056 -0.100549 25.7949 0.0682394 30.0965C0.308852 36.2651 0.355538 42.423 0.91577 48.5665C1.30307 52.6474 1.97872 56.6957 2.93763 60.6812C4.73325 68.042 12.0019 74.1676 19.1233 76.6666C26.7478 79.2728 34.9474 79.7055 42.8039 77.9162C43.6682 77.7151 44.5217 77.4817 45.3645 77.216C47.275 76.6092 49.5123 75.9305 51.1571 74.7385C51.1797 74.7217 51.1982 74.7001 51.2112 74.6753C51.2243 74.6504 51.2316 74.6229 51.2325 74.5948V68.6416C51.2321 68.6154 51.2259 68.5896 51.2142 68.5661C51.2025 68.5426 51.1858 68.522 51.1651 68.5058C51.1444 68.4896 51.1204 68.4783 51.0948 68.4726C51.0692 68.4669 51.0426 68.467 51.0171 68.4729C45.9835 69.675 40.8254 70.2777 35.6502 70.2682C26.7439 70.2682 24.3486 66.042 23.6626 64.2826C23.1113 62.762 22.7612 61.1759 22.6212 59.5646C22.6197 59.5375 22.6247 59.5105 22.6357 59.4857C22.6466 59.4609 22.6633 59.4391 22.6843 59.422C22.7053 59.4048 22.73 59.3929 22.7565 59.3871C22.783 59.3813 22.8104 59.3818 22.8367 59.3886C27.7864 60.5826 32.8604 61.1853 37.9522 61.1839C39.1768 61.1839 40.3978 61.1839 41.6224 61.1516C46.7435 61.008 52.1411 60.7459 57.1796 59.7621C57.3053 59.7369 57.431 59.7154 57.5387 59.6831C65.4861 58.157 73.0493 53.3672 73.8178 41.2381C73.8465 40.7606 73.9184 36.2364 73.9184 35.7409C73.9219 34.0569 74.4606 23.7949 73.8393 17.4898Z" fill="url(#linear-gradient-{{ $id }})"/>
         <path d="M61.2484 27.0263V48.114H52.8916V27.6475C52.8916 23.3388 51.096 21.1413 47.4437 21.1413C43.4287 21.1413 41.4177 23.7409 41.4177 28.8755V40.0782H33.1111V28.8755C33.1111 23.7409 31.0965 21.1413 27.0815 21.1413C23.4507 21.1413 21.6371 23.3388 21.6371 27.6475V48.114H13.2839V27.0263C13.2839 22.7176 14.384 19.2946 16.5843 16.7572C18.8539 14.2258 21.8311 12.926 25.5264 12.926C29.8036 12.926 33.0357 14.5705 35.1905 17.8559L37.2698 21.346L39.3527 17.8559C41.5074 14.5705 44.7395 12.926 49.0095 12.926C52.7013 12.926 55.6784 14.2258 57.9553 16.7572C60.1531 19.2922 61.2508 22.7152 61.2484 27.0263Z" fill="white"/>
         <defs>
-            <linearGradient id="paint0_linear_549_34" x1="37.0692" y1="0" x2="37.0692" y2="79" gradientUnits="userSpaceOnUse">
-                <stop stop-color="#6364FF"/>
+            <linearGradient id="linear-gradient-{{ $id }}" x1="37.0692" y1="0" x2="37.0692" y2="79" gradientUnits="userSpaceOnUse">
+                <stop offset="0" stop-color="#6364FF"/>
                 <stop offset="1" stop-color="#563ACC"/>
             </linearGradient>
         </defs>