From 483b3016ba0941699d6712327d5963d60016d68a Mon Sep 17 00:00:00 2001
From: Jonny Barnes <jonny@jonnybarnes.uk>
Date: Fri, 27 Oct 2023 20:33:43 +0100
Subject: [PATCH] refactor: Refactor PasskeysController and Passkey model

- Remove unused `use` statements and imports in `PasskeysController.php` and `Passkey.php`
- Improve code cleanliness and remove unnecessary dependencies
---
 app/Http/Controllers/Admin/PasskeysController.php | 12 +++++-------
 app/Models/Passkey.php                            |  1 -
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/app/Http/Controllers/Admin/PasskeysController.php b/app/Http/Controllers/Admin/PasskeysController.php
index e493926e..5fdca622 100644
--- a/app/Http/Controllers/Admin/PasskeysController.php
+++ b/app/Http/Controllers/Admin/PasskeysController.php
@@ -16,8 +16,6 @@ use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\App;
 use Illuminate\Support\Facades\Auth;
-use Illuminate\Support\Facades\Hash;
-use Illuminate\Support\Facades\Validator;
 use Illuminate\View\View;
 use ParagonIE\ConstantTime\Base64UrlSafe;
 use Throwable;
@@ -121,12 +119,12 @@ class PasskeysController extends Controller
 
         $attestationSupportManager = AttestationStatementSupportManager::create();
         $attestationSupportManager->add(NoneAttestationStatementSupport::create());
-        $attestationObjectLoader   = AttestationObjectLoader::create($attestationSupportManager);
+        $attestationObjectLoader = AttestationObjectLoader::create($attestationSupportManager);
         $publicKeyCredentialLoader = PublicKeyCredentialLoader::create($attestationObjectLoader);
 
         $publicKeyCredential = $publicKeyCredentialLoader->load(json_encode($request->all(), JSON_THROW_ON_ERROR));
 
-        if (!$publicKeyCredential->response instanceof AuthenticatorAttestationResponse) {
+        if (! $publicKeyCredential->response instanceof AuthenticatorAttestationResponse) {
             throw new WebAuthnException('Invalid response type');
         }
 
@@ -193,12 +191,12 @@ class PasskeysController extends Controller
 
         $attestationSupportManager = AttestationStatementSupportManager::create();
         $attestationSupportManager->add(NoneAttestationStatementSupport::create());
-        $attestationObjectLoader   = AttestationObjectLoader::create($attestationSupportManager);
+        $attestationObjectLoader = AttestationObjectLoader::create($attestationSupportManager);
         $publicKeyCredentialLoader = PublicKeyCredentialLoader::create($attestationObjectLoader);
 
         $publicKeyCredential = $publicKeyCredentialLoader->load(json_encode($request->all(), JSON_THROW_ON_ERROR));
 
-        if (!$publicKeyCredential->response instanceof AuthenticatorAssertionResponse) {
+        if (! $publicKeyCredential->response instanceof AuthenticatorAssertionResponse) {
             return response()->json([
                 'success' => false,
                 'message' => 'Invalid response type',
@@ -206,7 +204,7 @@ class PasskeysController extends Controller
         }
 
         $passkey = Passkey::firstWhere('passkey_id', $publicKeyCredential->id);
-        if (!$passkey) {
+        if (! $passkey) {
             return response()->json([
                 'success' => false,
                 'message' => 'Passkey not found',
diff --git a/app/Models/Passkey.php b/app/Models/Passkey.php
index 343fa40d..041a1b87 100644
--- a/app/Models/Passkey.php
+++ b/app/Models/Passkey.php
@@ -4,7 +4,6 @@ declare(strict_types=1);
 
 namespace App\Models;
 
-use Illuminate\Database\Eloquent\Casts\Attribute;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;