jonny/jonnybarnes.uk
1
0
Fork 0
Code Issues 5 Pull requests Projects Releases 5 Packages Wiki Activity Actions

Remove unwanted query parameters from normalized URLs

Browse source
This commit is contained in:
Jonny Barnes 2018-01-12 12:20:36 +00:00
parent 12a6b8f6b3
commit 6ccd564d56
2 changed files with 34 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
helpers.php
View file

@ -126,20 +126,33 @@ if (! function_exists('normalize_url')) {
// Sort GET params alphabetically, not because the RFC requires it but because it's cool! // Sort GET params alphabetically, not because the RFC requires it but because it's cool!
if (isset($url['query'])) { if (isset($url['query'])) {
if (preg_match('/&/', $url['query'])) { $queries = explode('&', $url['query']);
$s = explode('&', $url['query']);
$url['query'] = ''; $url['query'] = '';
sort($s); sort($queries);
foreach ($s as $z) { foreach ($queries as $query) {
$url['query'] .= "{$z}&"; //lets drop query params we don’t want
$key = stristr($query, '=', true);
if (queryKeyIsBanned($key) === false) {
$url['query'] .= "{$query}&";
}
} }
$url['query'] = preg_replace('/&\Z/', '', $url['query']); $url['query'] = preg_replace('/&\Z/', '', $url['query']);
} if ($url['query'] !== '') {
$newUrl .= "?{$url['query']}"; $newUrl .= "?{$url['query']}";
} }
}
return $newUrl; return $newUrl;
} }
function queryKeyIsBanned(string $key): bool
{
$bannedKeys = [
'ref_src',
];
return in_array($key, $bannedKeys);
}
} }
// sourced from https://stackoverflow.com/a/9776726 // sourced from https://stackoverflow.com/a/9776726

21
tests/Unit/HelpersTest.php
View file

@ -12,14 +12,6 @@ class HelpersTest extends TestCase
$this->assertEquals(normalize_url(normalize_url($input)), normalize_url($input)); $this->assertEquals(normalize_url(normalize_url($input)), normalize_url($input));
} }
/**
* @dataProvider urlProvider
*/
public function test_normalize_url($input, $output)
{
$this->assertEquals($output, normalize_url($input));
}
public function urlProvider() public function urlProvider()
{ {
return [ return [
@ -27,9 +19,22 @@ class HelpersTest extends TestCase
['https://example.org:443/', 'https://example.org'], ['https://example.org:443/', 'https://example.org'],
['http://www.foo.bar/index.php/', 'http://www.foo.bar'], ['http://www.foo.bar/index.php/', 'http://www.foo.bar'],
['https://example.org/?foo=bar&baz=true', 'https://example.org?baz=true&foo=bar'], ['https://example.org/?foo=bar&baz=true', 'https://example.org?baz=true&foo=bar'],
[
'http://example.org/?ref_src=twcamp^share|twsrc^ios|twgr^software.studioh.Indigenous.share-micropub',
'http://example.org',
],
]; ];
} }
/**
* @dataProvider urlProvider
* @group temp
*/
public function test_normalize_url($input, $output)
{
$this->assertEquals($output, normalize_url($input));
}
public function test_pretty_print_json() public function test_pretty_print_json()
{ {
$json = <<<JSON $json = <<<JSON