jonny/jonnybarnes.uk
1
0
Fork 0
Code Issues 5 Pull requests Projects Releases 5 Packages Wiki Activity Actions

refactor: Refactor and add tests for SaveProfileImage feature

Browse source 
- Add error handling checks for photo and home
- Add 3 new tests and modify an existing test for SaveProfileImageJob
- Test getting URL from photo object if alt text is provided
- Test using the first URL if multiple homepages are provided
This commit is contained in:
Jonny Barnes 2023-06-17 19:48:27 +01:00
parent 58ee36c932
commit dabd03f556
Signed by: jonny
SSH key fingerprint: SHA256:CTuSlns5U7qlD9jqHvtnVmfYV3Zwl2Z7WnJ4/dqOaL8
2 changed files with 67 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/Jobs/SaveProfileImage.php
View file

@ -42,6 +42,14 @@ class SaveProfileImage implements ShouldQueue
$photo = Arr::get($author, 'properties.photo.0'); $photo = Arr::get($author, 'properties.photo.0');
$home = Arr::get($author, 'properties.url.0'); $home = Arr::get($author, 'properties.url.0');
if (is_array($photo) && array_key_exists('value', $photo)) {
$photo = $photo['value'];
}
if (is_array($home)) {
$home = array_shift($home);
}
//dont save pbs.twimg.com links //dont save pbs.twimg.com links
if ( if (
$photo $photo

59
tests/Unit/Jobs/SaveProfileImageJobTest.php
View file

@ -106,4 +106,63 @@ class SaveProfileImageJobTest extends TestCase
public_path() . '/assets/profile-images/example.org/image' public_path() . '/assets/profile-images/example.org/image'
); );
} }
/** @test */
public function weGetUrlFromPhotoObjectIfAltTextIsProvided(): void
{
$mock = new MockHandler([
new Response(200, ['Content-Type' => 'image/jpeg'], 'fake jpeg image'),
]);
$handler = HandlerStack::create($mock);
$client = new Client(['handler' => $handler]);
$this->app->instance(Client::class, $client);
$mf = ['items' => []];
$author = [
'properties' => [
'photo' => [[
'value' => 'https://example.org/profile.jpg',
'alt' => null,
]],
'url' => ['https://example.org'],
],
];
$authorship = $this->createMock(Authorship::class);
$authorship->method('findAuthor')
->willReturn($author);
$job = new SaveProfileImage($mf);
$job->handle($authorship);
$this->assertFileExists(public_path() . '/assets/profile-images/example.org/image');
}
/** @test */
public function useFirstUrlIfMultipleHomepagesAreProvided(): void
{
$mock = new MockHandler([
new Response(200, ['Content-Type' => 'image/jpeg'], 'fake jpeg image'),
]);
$handler = HandlerStack::create($mock);
$client = new Client(['handler' => $handler]);
$this->app->instance(Client::class, $client);
$mf = ['items' => []];
$author = [
'properties' => [
'photo' => [[
'value' => 'https://example.org/profile.jpg',
'alt' => null,
]],
'url' => [[
'https://example.org',
'https://example.com',
]],
],
];
$authorship = $this->createMock(Authorship::class);
$authorship->method('findAuthor')
->willReturn($author);
$job = new SaveProfileImage($mf);
$job->handle($authorship);
$this->assertFileExists(public_path() . '/assets/profile-images/example.org/image');
}
} }