jonny/jonnybarnes.uk
1
0
Fork 0
Code Issues 5 Pull requests Projects Releases 5 Packages Wiki Activity Actions

Fix the number of queries being made

Browse source
This commit is contained in:
Jonny Barnes 2017-10-11 18:04:05 +01:00
parent d41d085853
commit f16034d963
3 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/Http/Controllers/BookmarksController.php
View file

@ -8,13 +8,15 @@ class BookmarksController extends Controller
{ {
public function index() public function index()
{ {
$bookmarks = Bookmark::with('tags')->latest()->paginate(10); $bookmarks = Bookmark::latest()->with('tags')->withCount('tags')->paginate(10);
return view('bookmarks.index', compact('bookmarks')); return view('bookmarks.index', compact('bookmarks'));
} }
public function show(Bookmark $bookmark) public function show(Bookmark $bookmark)
{ {
$bookmark->loadMissing('tags');
return view('bookmarks.show', compact('bookmark')); return view('bookmarks.show', compact('bookmark'));
} }
} }

2
resources/views/bookmarks/index.blade.php
View file

@ -20,7 +20,7 @@ Bookmarks «
@isset($bookmark->content) @isset($bookmark->content)
<p>{{ $bookmark->content }}</p> <p>{{ $bookmark->content }}</p>
@endisset @endisset
@if(count($bookmark->tags()->get()) > 0) @if($bookmark->tags_count > 0)
<ul> <ul>
@foreach($bookmark->tags as $tag) @foreach($bookmark->tags as $tag)
<li><a href="/bookmarks/tagged/{{ $tag->tag }}">{{ $tag->tag }}</a></li> <li><a href="/bookmarks/tagged/{{ $tag->tag }}">{{ $tag->tag }}</a></li>

2
resources/views/bookmarks/show.blade.php
View file

@ -18,7 +18,7 @@ Bookmark «
@isset($bookmark->content) @isset($bookmark->content)
<p>{{ $bookmark->content }}</p> <p>{{ $bookmark->content }}</p>
@endisset @endisset
@if(count($bookmark->tags()->get()) > 0) @if(count($bookmark->tags) > 0)
<ul> <ul>
@foreach($bookmark->tags as $tag) @foreach($bookmark->tags as $tag)
<li><a href="/bookmarks/tagged/{{ $tag->tag }}">{{ $tag->tag }}</a></li> <li><a href="/bookmarks/tagged/{{ $tag->tag }}">{{ $tag->tag }}</a></li>